-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3 unused php dependencies #1448
Conversation
…lehttp/guzzle and ocramius/lazy-property and edited run.sh and Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great removal of dependencies - thanks Lainey! Please revert the Makefile change, and let's get docker compose
working for you.
@laineyhm Github will auto link issues using the # syntax. You need to fix the issue link in the PR description so that the # and number are next to each other, so that the issue is linked correctly. |
…dev/web-languageforge into declutter-php-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
The following php dependencies are removed, as they are no longer being used by Language Forge:
aptoma/twig-markdown
ircmaxell/password-compat
michelf/php-markdown
Fixes #1447
Type of Change
cleanup
Testing on your branch
In docker, run the tests (
make unit-tests
,make playwright-tests
), runmake
and observe any missing/broken functionality or appearance that the tests might not have caughtChecklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org