Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3 unused php dependencies #1448

Merged
merged 8 commits into from
Sep 8, 2022
Merged

Conversation

laineyhm
Copy link
Collaborator

@laineyhm laineyhm commented Sep 6, 2022

Description

The following php dependencies are removed, as they are no longer being used by Language Forge:

aptoma/twig-markdown
ircmaxell/password-compat
michelf/php-markdown

Fixes #1447

Type of Change

cleanup

Testing on your branch

In docker, run the tests (make unit-tests, make playwright-tests), run make and observe any missing/broken functionality or appearance that the tests might not have caught

Checklist

  • [x ] I have performed a self-review of my own code
  • [x ] I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • [N/A ] I have commented my code, particularly in hard-to-understand areas
  • [N/A ] I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results

368 tests   368 ✔️  10s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 2a94bb6.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great removal of dependencies - thanks Lainey! Please revert the Makefile change, and let's get docker compose working for you.

docker/Makefile Outdated Show resolved Hide resolved
src/index.php Show resolved Hide resolved
src/index.php Show resolved Hide resolved
@megahirt
Copy link
Collaborator

megahirt commented Sep 6, 2022

@laineyhm Github will auto link issues using the # syntax. You need to fix the issue link in the PR description so that the # and number are next to each other, so that the issue is linked correctly.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@laineyhm laineyhm merged commit 7701a06 into develop Sep 8, 2022
@laineyhm laineyhm deleted the declutter-php-dependencies branch September 8, 2022 02:05
@laineyhm laineyhm restored the declutter-php-dependencies branch September 8, 2022 09:16
@laineyhm laineyhm deleted the declutter-php-dependencies branch September 8, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Audit unused PHP dependencies
2 participants