Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface language tests #1450

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Interface language tests #1450

merged 3 commits into from
Sep 8, 2022

Conversation

JeanneSon
Copy link
Contributor

@JeanneSon JeanneSon commented Sep 6, 2022

Description

The following tests have been converted to playwright

Interface Language picker (LF only so far)

✓ should be using English interface for user at Login

These tests were merged with other tests (because they were relying on each other)

✓ can change user interface language to French -> Can change user interface language to French, stays in French also on other pages, can change back to English
✓ should still be using French in another page -> Can change user interface language to French, stays in French also on other pages, can change back to English
✓ should still be using French back in the login page -> Can change user interface language to French, stays in French also on other pages, can change back to English
✓ can change user interface language to back English -> Can change user interface language to French, stays in French also on other pages, can change back to English

Type of Change

  • E2E tests

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@JeanneSon JeanneSon added the testing Pertaining to unit or e2e testing label Sep 6, 2022
@JeanneSon JeanneSon self-assigned this Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results

368 tests   368 ✔️  42s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit d186bc0.

♻️ This comment has been updated with latest results.

@JeanneSon JeanneSon changed the title Chore/interface language tests Interface language tests Sep 6, 2022
@JeanneSon JeanneSon marked this pull request as ready for review September 7, 2022 09:58
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one non-blocking suggestion!

test/e2e/interface-language.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
@JeanneSon JeanneSon merged commit de4c88e into develop Sep 8, 2022
@JeanneSon JeanneSon deleted the chore/interfaceLanguageTests branch September 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pertaining to unit or e2e testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants