Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified make's clean targets #1455

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Sep 9, 2022

Description

Over time, I've come to realize that the clean-volumes target wasn't really understood well and therefore unused. I decide to simply get rid of that use case altogether.

Type of Change

  • DX improvement

Screenshots

N/A

Testing on your branch

  • make clean should still shut down all services and clean up stopped containers
  • make clean-powerwash should get rid of all volumes, built images, dangling resources as well as build caches

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

@longrunningprocess longrunningprocess self-assigned this Sep 9, 2022
@longrunningprocess longrunningprocess added engineering Tasks which do not directly relate to a user-facing feature or fix cleanup labels Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results

368 tests   368 ✔️  12s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 93eb1b5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this is a nice all-around improvement!

@longrunningprocess longrunningprocess merged commit 75c0677 into develop Sep 13, 2022
@longrunningprocess longrunningprocess deleted the chore/simplify-make-clean branch September 13, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants