Lexicon new project tests #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanneSon
force-pushed
the
chore/lexiconNewProjectTests
branch
2 times, most recently
from
74a322f
to
a0e4ce9
Compare
JeanneSon
changed the title
JeanneSon
force-pushed
the
chore/lexiconNewProjectTests
branch
from
d8b6649
to
657d50c
Compare
myieye
reviewed
Sep 26, 2022
megahirt
force-pushed
the
chore/lexiconNewProjectTests
branch
from
657d50c
to
799cc37
Compare
alex-larkin
added
the
engineering
|
@myieye I will approve this PR if you can fix it up per your comments. If you have ideas how to make the two lines that Hanna marked as flaky, that would be great as well. Thanks! |
megahirt
added
the
blocked
|
I'm marking this as blocked until @myieye can pick this work up. |
myieye
force-pushed
the
chore/lexiconNewProjectTests
branch
from
39dbf40
to
899038a
Compare
myieye
removed
the
blocked
I wasn't able to make the flaky lines fail. So, we'll just wait and see. |
Details on how to run tests using either the Playwright VSCode extension, a make command, or mere commands in the command line.
The flaky tests are * Manager can delete if owner * Can successfully change user\'s password after form submission
E.g. "createUser" causes errors somtimes depending on user state and it's not at all obvious.
myieye
force-pushed
the
chore/lexiconNewProjectTests
branch
from
13f1b9c
to
02a3999
Compare
megahirt
approved these changes
Oct 5, 2022
|
I confirmed these tests passed on their run toward staging: https://github.com/sillsdev/web-languageforge/actions/runs/3189085647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
These tests test
Details
The following tests have been converted to playwright
Lexicon E2E New Project wizard app
✓ admin can get to wizard
✓ manager can get to wizard
✓ setup: user login and page contains a form
✓ cannot see Back or Next buttons
✓ can create a new project -> Can navigate to new project form and back
✓ can go back to Chooser page -> Can navigate to new project form and back
✓ can select Send and Receive -> Can navigate to Send and Receive form and back
✓ can go back to Chooser page -> Can navigate to Send and Receive form and back
✓ can get back to Send and Receive Credentials page
✓ cannot move on if Password is empty
✓ cannot move on if username is incorrect -> Cannot move on if username is incorrect and can go back to Chooser page, user and password preserved
✓ can go back to Chooser page, user and pass preserved -> Cannot move on if username is incorrect and can go back to Chooser page, user and password preserved
✓ cannot move on if Login is empty
✓ cannot move on if credentials are invalid
✓ can move on when the credentials are valid -> Can move on when the credentials are valid but cannot move further if no project is selected
✓ cannot move on if no project is selected -> Can move on when the credentials are valid but cannot move further if no project is selected
✓ cannot move on if not a manager of the project
✓ can move on when a managed project is selected
✓ can create a new project -> Cannot move on if name is invalid
✓ cannot move on if name is invalid -> Cannot move on if name is invalid
✓ finds the test project already exists
✓ with a cleared name does not show an error but is still invalid
✓ can verify that an unused project name is available
✓ can not edit project code by default
✓ can edit project code when enabled
✓ project code cannot be empty; does not show an error but is still invalid
✓ project code can be one character
✓ project code cannot be uppercase
✓ project code cannot start with a number
✓ project code cannot use non-alphanumeric -> Project code cannot use non-alphanumeric and reverts to default when Edit-project-code is disabled
✓ project code reverts to default when Edit-project-code is disabled -> Project code cannot use non-alphanumeric and reverts to default when Edit-project-code is disabled
The following tests were merged into one large test
Can create project, initial data page with upload & verify data
✓ can create project
✓ cannot see back button and defaults to uploading data -
✓ cannot upload large file
✓ cannot upload jpg
✓ can upload zip file
✓ displays stats
✓ displays non-critical errors
✓ can go to lexicon
✓ create: new empty project -> Create: new empty project & can skip uploading data
✓ can skip uploading data -> Create: new empty project & can skip uploading data
The following tests were merged into one large test
Primary Language page
✓ can go back to initial data page (then forward again)
✓ cannot move on if language is not selected
✓ can select language
✓ can search, select and add language
Deleted tests
✓ can clone project
✓ cannot move on while cloning
For details/remarks regarding the conversion of the tests, refer to the spreadsheet; https://docs.google.com/spreadsheets/d/1w9wjfm-02QHLhv0ObPAKKlqnDWeag379GIXwOcRU4W0/edit#gid=0
Type of Change
Checklist