Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Playwright to 1.25.2 #1462

Merged
merged 1 commit into from
Sep 14, 2022
Merged

upgrade Playwright to 1.25.2 #1462

merged 1 commit into from
Sep 14, 2022

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented Sep 14, 2022

Description

This brings us the latest version, and also fixes the remaining failing playwright tests on develop that use .filter()
In addition, I limit the workers to 1 for local runs, as our tests are not yet designed to be run in parallel (more work needed)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message

This brings us the latest version, and also fixes the remaining failing tests that use .filter()

In addition, I limit the workers to 1 for local runs, as our tests are not yet designed to be run in parallel (more work needed)
@megahirt megahirt self-assigned this Sep 14, 2022
@megahirt megahirt added the testing Pertaining to unit or e2e testing label Sep 14, 2022
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  8s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit e8c3aab.

Copy link
Contributor

@JeanneSon JeanneSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@megahirt megahirt enabled auto-merge (squash) September 14, 2022 09:24
@megahirt megahirt merged commit ecb1364 into develop Sep 14, 2022
@megahirt megahirt deleted the chore/upgradePlaywright branch September 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pertaining to unit or e2e testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants