Make make clean-powerwash delete base-php image
#1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
force-pushed
the
chore/fix-clean-powerwash
branch
from
26bd55b
to
c4317c3
Compare
The `docker compose down --rmi all` command doesn't appear to delete the base-php image, for reasons unknown. Since it occasionally will change, we'll just delete it explicitly in `make clean-powerwash`.
megahirt
force-pushed
the
chore/fix-clean-powerwash
branch
from
c4317c3
to
30dc24d
Compare
longrunningprocess
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a PR on @rmunn 's behalf
The
docker compose down --rmi allcommand doesn't appear to delete the base-php image, for reasons unknown. Since it occasionally will change, we'll just delete it explicitly inmake clean-powerwash.Type of Change
chore
I have performed a self-review of my own code
I have reviewed the title/description of this PR which will be used as the squashed PR commit message