Instructions for mobile device testing on a branch #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
force-pushed
the
mobile-branch-testing-instructions
branch
from
fe729de
to
265a753
Compare
|
I would like to get @longrunningprocess review before this is merged. |
longrunningprocess
previously requested changes
Sep 27, 2022
alex-larkin
added
the
engineering
There was a problem hiding this comment.
I really like those updates to the docs, thanks @megahirt , just one final question about the necessity of that platform line
We can use ngrok to create a URL that accesses what's in localhost from another device.
This allows us to access the unencrypted HTTP localhost if we want to, which is useful when used with ngrok
megahirt
force-pushed
the
mobile-branch-testing-instructions
branch
from
cc01515
to
d92686e
Compare
also add a TOC heading for mobile device testing
megahirt
force-pushed
the
mobile-branch-testing-instructions
branch
from
f3a32d2
to
6203f98
Compare
megahirt
approved these changes
Oct 7, 2022
megahirt
dismissed
longrunningprocess’s stale review
After cleaning up this PR, this is good to go. Just documentation change with the approved disable_https_redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can use ngrok to create a URL that accesses what's in localhost from another device. This allows us to test local branches' functionality on mobile devices. This PR adds instructions about how to do this to Developer.md.
Also, we disable HTTPS redirects in Caddy to facilitate easy ngrok usage
Fixes #1478
Type of Change
-Expanding developer instructions
Testing on your branch
N/A
Checklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org