Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template modifications #1493

Merged
merged 1 commit into from
Sep 29, 2022
Merged

PR template modifications #1493

merged 1 commit into from
Sep 29, 2022

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented Sep 29, 2022

Description

This is a bit of a circular thing to fill out the PR description for a PR that modifies the PR description template #1111

  • Reworded the testing sections to make it clearer how we should test and how we assign testers
  • move "Fixes issue" to top

This is in response to a discussion over on our retrospective board

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message

- rewording on testings sections
- move "Fixes issue" to top
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  8s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 3f92221.

@megahirt megahirt enabled auto-merge (squash) September 29, 2022 04:45
Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes!

@megahirt megahirt merged commit ae4e367 into develop Sep 29, 2022
@megahirt megahirt deleted the chore/prTemplate branch September 29, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants