Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other custom field dialog and related tests #1503

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

laineyhm
Copy link
Collaborator

@laineyhm laineyhm commented Oct 4, 2022

Fixes #1502

Description

This PR removes a custom fields modal created in the lex-modals.utils.ts file and tests that exercised it. This is code that I forgot to clean up in PR #1485.

Type of Change

Code/test cleanup.

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • The E2E tests should still all pass

qa.languageforge.org testing

Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org

  • Billy (2022-10-04) – confirmed e2e tests passed during develop merge
  • Tester2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results

368 tests   368 ✔️  8s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit e379395.

@laineyhm laineyhm enabled auto-merge (squash) October 4, 2022 05:03
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@laineyhm laineyhm merged commit 157bd75 into develop Oct 4, 2022
@laineyhm laineyhm deleted the remove-custom-field-modal branch October 4, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze tests that are using the 'Create Custom Fields' modal
2 participants