Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style page-header-detail for small viewports #1509

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

laineyhm
Copy link
Collaborator

@laineyhm laineyhm commented Oct 4, 2022

Fixes #1102

Description

This PR adds styling to the small and x-small viewport sizes -- Bootstrap media-breakpoint-down(sm) -- so that the page header detail displays nicely.

-The font-size of the project title is decreased
-The project title has text-overflow: ellipsis; overflow: hidden; and white-space: no-wrap properties, and the page-header detail has overflow: hidden
-The text of the Settings and Share buttons are removed, leaving just their icons.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • UI change

Screenshots

Before:
image

After:
image

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • Open developer tools or view from a small mobile device. Try with a project with a long title.

qa.languageforge.org testing

Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org

  • Billy (2022-10-04)
    image

  • Tester2 (YYYY-MM-DD HH:MM)

@laineyhm laineyhm enabled auto-merge (squash) October 4, 2022 08:42
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Unit Test Results

368 tests   368 ✔️  9s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 857c757.

♻️ This comment has been updated with latest results.

@laineyhm laineyhm merged commit 262bd5a into develop Oct 4, 2022
@laineyhm laineyhm deleted the titles-on-small-viewports branch October 4, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project titles not being handled well on small viewports
2 participants