Chore: Make our repo pretty

[myieye]

Part 2/3 of #1203

Description

Pretties all our code.

Type of Change

• Formatting

Checklist

• I have performed a self-review of my own code
• I have reviewed the title/description of this PR which will be used as the squashed PR commit message

[github-actions]

Unit Test Results

368 tests   368 ✔️  9s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 571f784.

♻️ This comment has been updated with latest results.

[longrunningprocess]

there are things in here I'd like to discuss more, maybe it would be good to do that at our next meeting.

[megahirt]

@longrunningprocess thanks for your review. I can see that the default Prettier code formatting is not in the style you prefer, so I would suggest that you check out https://prettier.io/playground/ and play around there with options so that when we have our meeting we can discuss different options.

I can tell you that we do have a strong preference for spaces, not tabs. In most other styles, I honestly don't care, so if there is a prettier option to make things more toward your likely I would be happy to integrate that.

The purpose of Prettier is not that we make things looking exactly how we'd like them, but that devs don't have to think at all about stylistic formatting when they develop. They simply write in the style they prefer (tabs! no-semi-colons!) and the code is consistently formatted on check-in in the same way for all devs.

Also check out the "Why Prettier" page for the motivation for why I believe it's worth doing: https://prettier.io/docs/en/why-prettier.html

[myieye]

I had forgotten to pretty-up our php code. I've updated the commits with those changes now.

[longrunningprocess]

I'm glad you went with husky and I like a bunch of the clean-ups, great work @myieye 🏆

[megahirt]

Tim, once this PR is merged, will you go and do a prettier commit on each open branch? Or do you recommend that the branch author do it using a documented command? For any open PRs, it would be great if you would do the commit directly and verify that the diff looks good on github. For other branches that are wip maybe the author should follow whatever directions you provide to run prettier - thoughts?

[myieye]

Tim, once this PR is merged, will you go and do a prettier commit on each open branch? Or do you recommend that the branch author do it using a documented command? For any open PRs, it would be great if you would do the commit directly and verify that the diff looks good on github. For other branches that are wip maybe the author should follow whatever directions you provide to run prettier - thoughts?

@megahirt I just requested devs to push any branches that might be missing (not really expecting anything).
I plan to do as many branches as are easy to tame 😆.
I'll document my approach soon 👍