Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Explicitly define & provide permissions for unit-tests workflow job #1534

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Oct 18, 2022

Fixes #1533

Description

Explicitly give the unit-tests job write permissions for checks & pull-requests. Writer permissions are required, but dependabot PRs only get read permissions by default.

Type of Change

  • Automation improvement

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message

@myieye myieye force-pushed the chore/1533-bug-dependabot-checks-fail branch from beea9d5 to 22674bf Compare October 18, 2022 13:22
@myieye myieye enabled auto-merge (squash) October 18, 2022 13:22
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@myieye myieye force-pushed the chore/1533-bug-dependabot-checks-fail branch from 22674bf to 4f438bc Compare October 19, 2022 12:42
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  8s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 4f438bc.

@myieye myieye changed the title Chore: Provide checks write permission for publishing test results Chore: Explicitly define & provide permissions for unit-tests workflow job Oct 19, 2022
@myieye myieye merged commit a0ab2eb into develop Oct 19, 2022
@myieye myieye deleted the chore/1533-bug-dependabot-checks-fail branch October 19, 2022 12:53
@myieye myieye self-assigned this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: dependabot checks fail
2 participants