Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the syntax for codec selection #1554

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Correct the syntax for codec selection #1554

merged 1 commit into from
Oct 25, 2022

Conversation

laineyhm
Copy link
Collaborator

@laineyhm laineyhm commented Oct 25, 2022

Fixes #1518

Description

I previously used the wrong ffmpeg option for setting the codec for the output file of conversion to WEBM. As a result, the converted files had an incompatible codec and container. This PR uses the right option, and files are successfully converted from OGG, FLAC, or M4A formats to WEBM format. I have verified the fix by playing back the files on Language Forge, as well as downloading them and inspecting them with ffprobe. Once this PR is staged, I will verify that the converted files work in FLEx.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Here is a folder of test files:
Audio Test Upload Files.zip

  • Upload the OGG, FLAC, and M4A files. Click the three dots next to the sound player and examine the file names. They should be WEBM files. Play them. They should play back in Language Forge. Download them and inspect the file size. It should be >0KB.

qa.languageforge.org testing

Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org

  • Tester1 (YYYY-MM-DD HH:MM)
  • Tester2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  12s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 894fa83.

@myieye
Copy link
Collaborator

myieye commented Oct 25, 2022

Tried it locally 👍

@laineyhm laineyhm merged commit d525e6f into develop Oct 25, 2022
@laineyhm laineyhm deleted the fix-audio-files branch October 25, 2022 09:46
@longrunningprocess longrunningprocess added the bug An existing problem with our app in production label Oct 25, 2022
@longrunningprocess
Copy link
Contributor

✅ tested in staging, all played correctly as well

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants