Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable playwright tests in deployment workflow #1558

Merged

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Oct 25, 2022

Description

Playwright tests seem to be pretty stable now, so we can reenable them in the deployment workflow/job.

I removed the browser caching steps with the thought that deployment doesn't run often enough for them to add as much value as they do complexity.

Type of Change

  • New feature (reenabling workflow step)

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Ran the workflow here and the playwright steps are green: https://github.com/sillsdev/web-languageforge/actions/runs/3322471978

@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Unit Test Results

368 tests   368 ✔️  8s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit 804bc33.

♻️ This comment has been updated with latest results.

@myieye
Copy link
Collaborator Author

myieye commented Oct 25, 2022

Uncovered a flaky test: https://github.com/sillsdev/web-languageforge/actions/runs/3322410002/jobs/5491390263
So, I'll fix that up before merging this.

@myieye myieye force-pushed the chore/reenable-playwright-tests-in-deployment-workflow branch from 5fbd495 to e02203f Compare October 25, 2022 16:27
@longrunningprocess
Copy link
Contributor

Uncovered a flaky test: https://github.com/sillsdev/web-languageforge/actions/runs/3322410002/jobs/5491390263 So, I'll fix that up before merging this.

I just noted this on the other PR, thanks Tim!

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I'm very happy to see that we are at this point again with E2E tests

@myieye myieye marked this pull request as ready for review November 17, 2022 10:37
@myieye myieye merged commit dc30065 into develop Nov 17, 2022
@myieye myieye deleted the chore/reenable-playwright-tests-in-deployment-workflow branch November 17, 2022 15:46
@longrunningprocess
Copy link
Contributor

Testing

GTG on develop run ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants