Disable adding to options lists #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
approved these changes
Oct 28, 2022
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
|
TESTED I observe that the add item button is gone and the appropriate message to use FLEx is displayed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1552
Description
Because options added or deleted in Language Forge are not being received into FLEx properly, we want to disable adding (deletion is already disabled) them in Language Forge. Because we may wish to restore this functionality in the future, with a better architecture to ensure synchronization, this PR takes out as little code as possible while preventing users from making these edits for the time being.
Type of Change
Screenshots
Before:
After:
Checklist
How to test
General smoke test, and:
Navigate to the Options List tab of Configuration. Ensure that the text input and '+ Add to List' button are removed and a message at the top of each options list node reads "To add or remove items from this list, please use FieldWorks (FLEx)."
qa.languageforge.org testing
Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org