Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporated retro feedback into pr template #1566

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

longrunningprocess
Copy link
Contributor

Description

This PR updates the PR template according to discussions on our last retrospective

Type of Change

  • This change requires a documentation update

Screenshots

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Open a new PR after merged in develop and ensure the changes have taken effect.

qa.languageforge.org testing

@longrunningprocess longrunningprocess enabled auto-merge (squash) October 27, 2022 18:58
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  9s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 5d5dcde.

@longrunningprocess longrunningprocess self-assigned this Oct 27, 2022
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@longrunningprocess longrunningprocess merged commit d45eded into develop Oct 28, 2022
@longrunningprocess longrunningprocess deleted the chore/update-pr-template branch October 28, 2022 09:18
@megahirt
Copy link
Collaborator

megahirt commented Nov 1, 2022

TESTED

The PR template has been updated as expected when I create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants