Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded docker action to eliminate more GHA deprecation warnings #1569

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

longrunningprocess
Copy link
Contributor

Description

While testing #1565 , I noticed more deprecation warnings in the deployment run on develop: https://github.com/sillsdev/web-languageforge/actions/runs/3345899140. This PR will aim to reduce those as much as possible.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Double check the workflow run on a merge to develop and ensure there are no deprecation warnings.

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess self-assigned this Oct 28, 2022
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  10s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit a7ef8bd.

@longrunningprocess longrunningprocess enabled auto-merge (squash) October 28, 2022 19:04
@longrunningprocess longrunningprocess merged commit d331b9f into develop Oct 29, 2022
@longrunningprocess longrunningprocess deleted the chore/remove-gha-deprecation-warnings branch October 29, 2022 01:20
@megahirt
Copy link
Collaborator

megahirt commented Nov 1, 2022

TESTED

I observe no Github Actions warnings or errors in recent builds or tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants