-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliminate notifications for offline/online status #1573
eliminate notifications for offline/online status #1573
Conversation
If we don't want to go quickly with this, I can also add commits for whatever a final solution might look like including the removal of the https://github.com/hubspot/offline dep as well as migration to the modern approach: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/onLine#Specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I would like to go fast on this, and just delete those sections outright, not just comment out.
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
I'm with you, I'd like to get this back in Erika's hands ASAP |
TESTED I observe that no notifications are created when simulating going on/off line. The header still has the offline text and color change as expected. |
Fixes #1571
Description
This PR seeks to quiet down the LF notification system when detecting online/offline status.
Type of Change
Only keep lines below that describe this change, then delete the rest.
Screenshots
Without the notifications:
Screen.Recording.2022-10-31.at.12.57.26.PM.mov
Checklist
How to test
qa.languageforge.org testing
Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.