Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate notifications for offline/online status #1573

Merged
merged 6 commits into from
Nov 1, 2022

Conversation

longrunningprocess
Copy link
Contributor

Fixes #1571

Description

This PR seeks to quiet down the LF notification system when detecting online/offline status.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Without the notifications:

Screen.Recording.2022-10-31.at.12.57.26.PM.mov

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • Go offline (via your wifi or dev tools->Network->Offline) and ensure the top app bar changes colors and the header title shows "Offline"

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess self-assigned this Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

Unit Test Results

368 tests   368 ✔️  14s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit 518845d.

♻️ This comment has been updated with latest results.

@longrunningprocess
Copy link
Contributor Author

If we don't want to go quickly with this, I can also add commits for whatever a final solution might look like including the removal of the https://github.com/hubspot/offline dep as well as migration to the modern approach: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/onLine#Specification

@longrunningprocess longrunningprocess enabled auto-merge (squash) October 31, 2022 19:00
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I would like to go fast on this, and just delete those sections outright, not just comment out.

billy clark and others added 5 commits October 31, 2022 20:17
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
Co-authored-by: Christopher Hirt <chris@hirtfamily.net>
@longrunningprocess
Copy link
Contributor Author

LGTM I would like to go fast on this, and just delete those sections outright, not just comment out.

I'm with you, I'd like to get this back in Erika's hands ASAP

@longrunningprocess longrunningprocess merged commit bd1bea0 into develop Nov 1, 2022
@longrunningprocess longrunningprocess deleted the bugfix/distracting-offline-messages branch November 1, 2022 00:27
@megahirt
Copy link
Collaborator

megahirt commented Nov 1, 2022

TESTED

I observe that no notifications are created when simulating going on/off line. The header still has the offline text and color change as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: online/offline messages are distracting and unnecessary for flaky connections that mostly work
2 participants