Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made stats clickable under the right circumstances #1578

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Nov 3, 2022

Fixes #1525

Description

The PR will make stat cards on the project dashboard clickable now. I could not determine a deep link for the Users card so I left that one alone for now.

Type of Change

  • New feature (non-breaking change which adds functionality)

Screenshots

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Head to the dashboard for a project

  • Ensure the users card is not clickable
  • Ensure any cards with 0 value are not clickable
  • Ensure any cards, other than Users, that have values, are clickable
  • Ensure when a card is clickable, the cursor changes to a pointer finger when hovering over the card
  • Ensure clicking on the cards goes to the correct page

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess self-assigned this Nov 3, 2022
@longrunningprocess longrunningprocess requested review from megahirt and removed request for megahirt November 3, 2022 19:42
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Unit Test Results

368 tests   368 ✔️  14s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit f43b98a.

@longrunningprocess longrunningprocess enabled auto-merge (squash) November 3, 2022 20:13
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @longrunningprocess

@longrunningprocess longrunningprocess merged commit 3926eef into develop Nov 4, 2022
@longrunningprocess longrunningprocess deleted the feature/clickable-stats branch November 4, 2022 05:45
@megahirt
Copy link
Collaborator

megahirt commented Nov 4, 2022

TESTED:

  • Ensure the users card is not clickable
  • Ensure any cards with 0 value are not clickable
  • Ensure any cards, other than Users, that have values, are clickable
  • Ensure when a card is clickable, the cursor changes to a pointer finger when hovering over the card
  • Ensure clicking on the cards goes to the correct page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Clickable stats on project landing page
2 participants