Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified version stamping #1583

Merged
merged 8 commits into from
Nov 8, 2022
Merged

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Nov 7, 2022

Fixes #1582

Description

This PR seeks to simplify the legacy app's version stamping process

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • Once deployed, pop open devtools and ensure the cache-buster on UI assets looks correct for that environment.

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess enabled auto-merge (squash) November 7, 2022 16:18
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Unit Test Results

368 tests   368 ✔️  9s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit 9e0771c.

♻️ This comment has been updated with latest results.

@longrunningprocess longrunningprocess enabled auto-merge (squash) November 7, 2022 18:46
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for finding and fixing this, @longrunningprocess

@longrunningprocess longrunningprocess merged commit 652076c into develop Nov 8, 2022
@longrunningprocess longrunningprocess deleted the bugfix/cache-buster-broken branch November 8, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ui cache-buster's not correct after v2022-10-19
2 participants