Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize HTML title for tooltips #1597

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Nov 15, 2022

Fixes #1595

Description

Althought HTML's title= is a bit unreliable across browsers and ill-advised for a11y reasons, we've decided to go ahead with them for sake of those users who will benefit from them as toottips.

Type of Change

  • UI change

Screenshots

Screen.Recording.2022-11-15.at.1.41.57.PM.mov

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

  • Create an entry and hover over the trash can icon and ensure you see a tooltip.
  • Create enough meanings to hover over the trash can, up and down arrow keys to see each of the tooltips and ensure they are correct.
  • Create enough examples to hover over the trash can, up and down arrow keys to see each of the tooltips and ensure they are correct.

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess self-assigned this Nov 15, 2022
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  12s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit 752c07e.

@longrunningprocess longrunningprocess enabled auto-merge (squash) November 15, 2022 18:48
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longrunningprocess longrunningprocess merged commit 1adf582 into develop Nov 15, 2022
@longrunningprocess longrunningprocess deleted the provide-native-tooltips branch November 15, 2022 22:09
@josephmyers
Copy link
Contributor

Ran through this on QA. Looks good, love me some toottips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use old title= technique to get cheap hovers
3 participants