Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing punctuation #1598

Merged
merged 1 commit into from
Nov 15, 2022
Merged

added missing punctuation #1598

merged 1 commit into from
Nov 15, 2022

Conversation

longrunningprocess
Copy link
Contributor

@longrunningprocess longrunningprocess commented Nov 15, 2022

Fixes #1596

Description

This PR adds missing punctuation found in testing recently.

Type of Change

  • UI change

Screenshots

N/A

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Attempt to delete an entry and ensure there is a question mark in the chicken page
  • Attempt to delete an audio file and ensure there is a question mark in the chicken page
  • Attempt to delete a meaning and ensure there is a question mark in the chicken page
  • Attempt to delete a picture and ensure there is a question mark in the chicken page
  • Attempt to delete an example and ensure there is a question mark in the chicken page

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@longrunningprocess longrunningprocess self-assigned this Nov 15, 2022
@longrunningprocess longrunningprocess enabled auto-merge (squash) November 15, 2022 19:24
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  9s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit a7c7ce4.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@longrunningprocess longrunningprocess merged commit 0047e99 into develop Nov 15, 2022
@longrunningprocess longrunningprocess deleted the was-that-a-question branch November 15, 2022 22:07
@josephmyers
Copy link
Contributor

Ran through the bullet points on QA. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing punctuation
3 participants