Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving playwright.config.ts #1603

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Nov 17, 2022

Description

In #1557 I moved the playwright.config.ts file to the playwright test folder. But I overlooked a few things:

  1. That affected where test results get stored
  2. It affects where storageState.json files get created when running tests via VS-Code extension

So, I've fixed and standardized those things.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas

@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  11s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit fe275fe.

Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice changes 🏆

Makefile Show resolved Hide resolved
@myieye myieye merged commit daeda8d into develop Nov 17, 2022
@myieye myieye deleted the chore/fix-moving-playwright.config branch November 17, 2022 15:34
@longrunningprocess
Copy link
Contributor

Testing

E2E testing on develop run and deployment seem like a good test for this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants