Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make empty projects display correctly for non-managers #1606

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

laineyhm
Copy link
Collaborator

Fixes #1605

Description

This allows the message "Looks like there are no entries yet." to appear for any member of the project (including commenters), and the two buttons to appear for any member of the project who can edit. Previously, with empty projects, these items only displayed if the member was a manager (to include owners and admins, but not editors or commenters).

image

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)
  • UI change

Screenshots

This is what we were seeing before, for anyone with permissions less than a manager's:
image

Now viewers and commenters will see this:
image

and editors, managers, and above will see this:
image

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

How to test

1.Create an empty project and share it with another user, giving them only the (default) "can edit" permissions. Sign in as the other user and view the project. Verify that you see the message and can add entries if you like.
2.Create an empty project and share it with another user, giving them view or comment permissions only. Sign in as the other user and view the project. Verify that you see the message and can add entries if you like.

qa.languageforge.org testing

Testers should add his/her findings to end of the PR in a comment and include screenshots, files, etc that are beneficial.

@laineyhm laineyhm enabled auto-merge (squash) November 18, 2022 06:59
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  10s ⏱️
  38 suites      0 💤
    1 files        0

Results for commit 4fd89bb.

Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - well done!

@laineyhm laineyhm merged commit 4cc056a into develop Nov 18, 2022
@laineyhm laineyhm deleted the update-editor-component-permissions branch November 18, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: editor component of empty project blank for users who aren't managers, owners, admins
2 participants