Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse recs #1741

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Lighthouse recs #1741

wants to merge 5 commits into from

Conversation

laineyhm
Copy link
Collaborator

@laineyhm laineyhm commented Mar 23, 2023

Fixes #1740

Description

Remove jquery; cache files; add references, robots.txt, and sourcemaps

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

Click the links on the homepage; everything should work even without JQuery.
Run the Lighthouse report in the Chrome Developer Tools. Feedback should not include warnings about

  • an invalid robots.txt file
  • very many uncached items
  • missing sourcemaps for main.bundle.js, manifest.bundle.js, or vendor.bundle.js

@laineyhm laineyhm added the bug An existing problem with our app in production label Mar 23, 2023
@github-actions
Copy link

github-actions bot commented Mar 23, 2023

Unit Test Results

362 tests   362 ✅  13s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit e2cfb40.

♻️ This comment has been updated with latest results.

@laineyhm laineyhm marked this pull request as ready for review March 24, 2023 07:17
@laineyhm laineyhm enabled auto-merge (squash) March 24, 2023 07:17
@megahirt megahirt disabled auto-merge May 21, 2024 07:18
@megahirt megahirt force-pushed the lighthouse-recs branch 2 times, most recently from 162daa9 to e4aef2c Compare June 27, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse report recommendations
2 participants