Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent UI updates when there is an unresolved recording in progress #1763

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Jun 21, 2023

Fixes #1762

Description

See #1762

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

  1. Make various changes to entries while recording, while uploading or anywhere in between and make sure the recording never gets lost.

@myieye myieye added the bug An existing problem with our app in production label Jun 21, 2023
@github-actions
Copy link

Unit Test Results

362 tests   362 ✔️  16s ⏱️
  37 suites      0 💤
    1 files        0

Results for commit 4d28d8c.

Copy link
Collaborator

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The bit where we block UI updates if an upload is in progress might in theory have a better solution, but implementing that better solution would involve a LOT more work than it's worth considering that nobody will notice the UI updates being blocked in 99.8% of cases. So let's get this merged.

@myieye myieye merged commit 8d0a15e into develop Jun 22, 2023
@myieye myieye deleted the bug/1762-bug-ui-refreshes-often-cause-audio-loss branch June 22, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: UI refreshes often cause audio loss
2 participants