Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var for pointing app at lexbox #1768

Merged

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Jul 13, 2023

Fixes #1767

Description

We want LexBox to get as much "real" use as possible, so we plan to point the staging environment at it for fetching the list of LD projects.

As is obvious in the change set, I tested this against lexbox locally and in staging. Referencing db as lf-db was necessary, because both docker networks had a db.

This won't work (at the time of writing), because the LexBox API only supports form-data, which is what Chorus sends. It might be safe to just change lf-classic to do the same, but it feels a bit better supporting both, because 🤷 there might be another service sending json.

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have enabled auto-merge (optional)

Testing

We'll turn this on in staging, once LexBox supports JSON.

@myieye myieye added the engineering Tasks which do not directly relate to a user-facing feature or fix label Jul 13, 2023
@github-actions
Copy link

Unit Test Results

362 tests   362 ✔️  19s ⏱️
  37 suites      0 💤
    1 files        0

Results for commit 45916ad.

@myieye myieye force-pushed the feat/add-env-var-for-pointing-project-getter-at-lexbox branch from 45916ad to 4469874 Compare July 13, 2023 15:13
@myieye myieye merged commit 0fb3fb3 into develop Jul 13, 2023
1 of 15 checks passed
@myieye myieye deleted the feat/add-env-var-for-pointing-project-getter-at-lexbox branch July 13, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace hard coded host name in SendReceiveCommands with environment variable based config
1 participant