Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt additional prettier checks on PR builds #1778

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

megahirt
Copy link
Collaborator

I have observed failing code formatting checks
on CI that don't fail locally, e.g. #1777 had a failed code formatter check. Attempting to get more info with this PR.

@megahirt megahirt added the engineering Tasks which do not directly relate to a user-facing feature or fix label Sep 21, 2023
@megahirt megahirt self-assigned this Sep 21, 2023
@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Unit Test Results

362 tests   362 ✔️  15s ⏱️
  37 suites      0 💤
    1 files        0

Results for commit 5e0d200.

♻️ This comment has been updated with latest results.

@megahirt megahirt force-pushed the chore/debugPrettier branch 3 times, most recently from 644d21c to 213f218 Compare September 22, 2023 00:55
I have observed failing code formatting checks
on CI that don't fail locally for v2.7.
Copy link
Collaborator

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting and slightly mysterious. Your changes certainly look like an improvement. 👍

@myieye myieye merged commit a333837 into develop Oct 2, 2023
17 checks passed
@myieye myieye deleted the chore/debugPrettier branch October 2, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants