Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node.js version to 18 #1795

Closed
wants to merge 1 commit into from
Closed

Bump node.js version to 18 #1795

wants to merge 1 commit into from

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Apr 30, 2024

Fixes #1792

Description

Node 22 just came out, so we want to upgrade off of Node 16 which is going end-of-life today (end of April 2024). As a first step, we'll move to Node 18/.

This requires upgrading webpack, as webpack 5.27.1 used a feature of older Node versions that is deprecated in Node 18 and above. No other NPM package upgrades have been required yet; once we're running a modern version of Node, I'll upgrade more NPM packages.

Screenshots

N/A

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

  • Run make, make sure site still loads. That's about it.

Requires upgrading webpack, as webpack 5.27.1 used a feature of older
Node versions that is deprecated in Node 18 and above.
@rmunn rmunn self-assigned this Apr 30, 2024
Copy link

Unit Test Results

362 tests   362 ✅  12s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit 484b3a5.

@rmunn rmunn added the engineering Tasks which do not directly relate to a user-facing feature or fix label Apr 30, 2024
@megahirt
Copy link
Collaborator

Actually, Node 16 went EOL in Sept 2023.

@megahirt
Copy link
Collaborator

Superseded by #1797

@megahirt megahirt closed this Apr 30, 2024
@megahirt megahirt deleted the chore/bump-node-to-18 branch April 30, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Bump Node.js to version 18
2 participants