Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm packages #1799

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Update npm packages #1799

merged 2 commits into from
Apr 30, 2024

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Apr 30, 2024

Fixes #1798

Description

Updated NPM packages by running npm up. This did not update all packages, because in some cases we've put fixed version numbers into package.json rather than versions like ^1.2 which would pull any 1.x package. But this is a start.

Also had to add one line to tsconfig.json, because our suppressImplicitAnyIndexErrors config is deprecated since Typescript 5.0 and will go away in Typescript 5.5. But this PR updates to Typescript 5.4.5, so we don't (yet) have to go through and add individual @ts-ignore comments before each occurrence of implicit "any" types. That's coming soon, though.

Screenshots

No behavioral changes.

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

  • Run make, make sure site still loads.

@rmunn rmunn added the engineering Tasks which do not directly relate to a user-facing feature or fix label Apr 30, 2024
@rmunn rmunn self-assigned this Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Unit Test Results

362 tests   362 ✅  12s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit 680e878.

♻️ This comment has been updated with latest results.

This is the result of running `npm up` across the board.
The suppressImplicitAnyIndexErrors config is deprecated in Typescript
5.0 and above, and will be removed in Typescript 5.5. For now, we can
still use it by setting "ignoreDeprecations": "5.0", but we'll need to
go through our JS code and switch to individual @ts-ignore lines at
every occurrence of implicit "any" before we can update to TS 5.5.
@rmunn rmunn force-pushed the chore/update-npm-packages branch from 797c098 to 680e878 Compare April 30, 2024 06:52
@megahirt
Copy link
Collaborator

megahirt commented Apr 30, 2024

Curiously, after 3 re-runs, the Firefox shard 2/6 playwright E2E tests consistently fail for two tests (they all pass in Chromium):

2 failed
[firefox] › editor/editor.entries.spec.ts:207:7 › Editor entries › Create new word, modify new word, autosaves changes, new word visible in editor and list
[firefox] › editor/editor.pictures.spec.ts:53:7 › Editor pictures › Showing and hiding captions
17 passed (3.1m)

I'm in favor of merging this with a separate issue to look into the two failing tests

@rmunn rmunn requested a review from megahirt April 30, 2024 09:17
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is very welcome and an important security update for all our NPM packages. The playwright E2E tests all pass on chromium reliably but curiously 2 tests fail on Firefox. More investigation is needed but I don't want to hold up merging this. So I will create a separate issue for the 2 failing Firefox tests.

@rmunn rmunn enabled auto-merge (squash) April 30, 2024 09:25
@megahirt megahirt disabled auto-merge April 30, 2024 09:26
@rmunn rmunn merged commit 510b824 into develop Apr 30, 2024
15 of 17 checks passed
@rmunn rmunn deleted the chore/update-npm-packages branch April 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Update NPM packages
2 participants