Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tiny documentation updates and fix docker compose version warning #1808

Merged
merged 4 commits into from
May 7, 2024

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented May 3, 2024

Description

Updates documentation to reflect that we no longer encourage WSL development. Updated references to Node 22 and PHP 7.4

Removed the docker compose version from the yml file because that was causing a warning message.

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

@megahirt megahirt added the engineering Tasks which do not directly relate to a user-facing feature or fix label May 3, 2024
@megahirt megahirt self-assigned this May 3, 2024
@megahirt megahirt enabled auto-merge (squash) May 3, 2024 09:05
Copy link

github-actions bot commented May 3, 2024

Unit Test Results

362 tests   362 ✅  13s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit 0e767e2.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@megahirt megahirt disabled auto-merge May 7, 2024 10:18
@megahirt megahirt merged commit 8a6b4e2 into develop May 7, 2024
15 of 17 checks passed
@megahirt megahirt deleted the chore/tidy branch May 7, 2024 10:19
@megahirt
Copy link
Collaborator Author

megahirt commented May 7, 2024

bypassed the failing e2e tests on firefox - these are not real failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants