Fix one failing E2E test on Firefox, skip the other one #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results362 tests 362 ✅ 12s ⏱️ Results for commit dba024c. ♻️ This comment has been updated with latest results. |
myieye
reviewed
May 6, 2024
It seems that reloading the page immediately after editing an entry isn't triggering the autosave on Firefox. We can work around this by navigating to another entry before reloading, which does trigger the autosave.
There appears to be a Playwright bug with locator.fill() on Firefox, where the locator waits forever for the textarea to be editable. This happens even if you have added "expect(...).toBeEditable()" immediately before the locator.fill(). Since this bug appears to be Firefox-specific, we will simply skip this test on Firefox until the bug is solved.
rmunn
force-pushed
the
debt/failing-firefox-e2e
branch
from
63cf775
to
0ec6a7e
Compare
Firefox is slower on this test for some reason, and we do want to make sure it doesn't time out and make an otherwise-green test run go red.
myieye
approved these changes
May 10, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1801
Description
We currently have two E2E tests that fail on Firefox while they pass on Chrome.
One of them appears to be caused by
reload()not triggering our page autosave when it happens immediately after alocator.fill(). I suspect that thereload()isn't triggering theblurevent which would allow our autosave to trigger, but only on Firefox (for reasons that would take so long to determine that I figure it's not worth spending the time). I solved this one by clicking on another entry before running thereload(), which forces the just-entered data to autosave and thus the rest of the test passes as it should.The other test appears to be running into a Playwright bug with
locator.fill()on Firefox, where the locator thinks the input field (or textarea in this case) is not editable. This happens even if you putexpect(...).toBeEditable()immediately before the.fill(). Theexpectpasses, but then the locator waits forever (or rather, until the test times out) for the text area to be editable, for some reason not realizing that it is editable. Since this appears to be caused by a Playwright and/or Firefox bug rather than by our code, and the test passes in Chromium, I decided to simply have this test skipped on Firefox until such time as thelocator.fill()bug gets resolved.Checklist
Testing
npm run test-e2e; all E2E tests should now pass.