Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of symfony-exceptions.patch #1815

Merged
merged 2 commits into from
May 22, 2024
Merged

Get rid of symfony-exceptions.patch #1815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7965d0a
Get rid of symfony-exceptions.patch
rmunn May 21, 2024
e685f1d
Simply comment out the appropriate Dockerfile lines
rmunn May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docker/app/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ RUN chown -R www-data:www-data /var/www/html/assets /var/www/html/cache \

COPY --from=composer-builder /composer/vendor /var/www/html/vendor

# patch exception handling from Symfony to actually show exceptions instead of swallowing them
COPY docker/app/symfony-exceptions.patch /
RUN patch -p4 -i /symfony-exceptions.patch
# Uncomment the two lines below if you see Symfony errors like "expected Exception, got Error instead"
# This will allow you to see the actual underlying error, rather than the Symfony exception that hides the underlying one
# COPY docker/app/symfony-exceptions.patch /
# RUN patch -p4 -i /symfony-exceptions.patch

RUN echo "${BUILD_VERSION}" > build-version.txt \
&& sed -i "s/9.9.9/${BUILD_VERSION}/" version.php
Expand Down
Loading