Fix "implicit any" Typescript errors to prepare for Typescript 5.5 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript 5.5 disallows the "suppressImplicitAnyIndexErrors", so we need to go through the code, find any places where an index has an implicit "any" type, and annotate those places with the correct type so that Typescript won't complain about them. This commit makes a start on this task.
In a couple places, we do `if foo.hasOwnProperty(bar)` followed by getting the value of `foo[bar]`, but Typescript warns that "string" isn't a valid property name of `foo`. It should recognize that the hasOwnProperty check means it's safe to access `foo[bar]`, but it doesn't. We can either change those to be `if bar in foo` which Typescript *does* recognize as a type guard, or else we can just leave the code as-is and add @ts-expect-error comments. Since `bar in foo` is not quite identical to `foo.hasOwnProperty(bar)` (`bar in foo` climbs inheritance hierarchies whereas `.hasOwnProperty` doesn't), I chose to leave the code as-is rather than subtly change its behavior.
Now that we've fixed the implicit "any" index errors, we can remove this line from tsconfig. (It will be going away in Typescript 5.5 anyway).
rmunn
added
the
engineering
Unit Test Results362 tests 362 ✅ 13s ⏱️ Results for commit c92e2e6. |
hahn-kev
reviewed
May 22, 2024
myieye
approved these changes
May 24, 2024
hahn-kev
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1800
Description
We currently have
suppressImplicitAnyIndexErrorsin our tsconfig.json since we have a lot of implicitanytypes scattered throughout our code. That option will be going away in Typescript 5.5, so we need to fix them now so that we can continue to upgrade Typescript in the future (5.5 is currently in beta).Screenshots
No behavioral changes.
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
make, make sure site still loads.