Test againt Ruby 2.2 on Travis CI #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkdynamic
added a commit
that referenced
this pull request
Nov 9, 2015
Test againt Ruby 2.2 on Travis CI
|
Thanks! |
| @@ -158,6 +158,7 @@ If you use the server-side flow, Facebook will give you back a longer lived acce | |||
|
|
|||
| Actively tested with the following Ruby versions: | |||
|
|
|||
| - MRI 2.2.0 | |||
| - MRI 2.1.0 | |||
There was a problem hiding this comment.
Aren't we testing only the latest minor version? For example for 2.1 I can see there's 2.1.5 tested on CI.
There was a problem hiding this comment.
Seems right.
Currently this version is incorrect.
But patch version in README is hardly to maintain.
Might it be 2.1 or 2.1.x ?
There was a problem hiding this comment.
Agreed.
I send a new PR: #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.