Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dynamic import statements #7

Closed
raphaelschwinger opened this issue Mar 10, 2021 · 1 comment
Closed

remove dynamic import statements #7

raphaelschwinger opened this issue Mar 10, 2021 · 1 comment

Comments

@raphaelschwinger
Copy link
Contributor

raphaelschwinger commented Mar 10, 2021 •
edited
Loading

Thanks @simov for your great work again! This is the same as in your other repo

Summary

Importing from paths generated at runtime breaks
parcel, see (parcel-bundler/parcel#4031),
or esbuild, see (evanw/esbuild#480).
This can lead to problems at runtime.

fixes #7
@raphaelschwinger raphaelschwinger mentioned this issue Mar 10, 2021
Closed
@simov
Copy link
Owner

simov commented Mar 20, 2021

Fixed in #8

@simov simov closed this as completed Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove-dynamic-imports raphaelschwinger/request-compose
2 participants
@simov @raphaelschwinger