Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add channels group to rails profile #492

Closed
wants to merge 1 commit into from
+1 −0
Closed

add channels group to rails profile #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/simplecov/defaults.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
add_filter "/db/"

add_group "Controllers", "app/controllers"
add_group "Channels", "app/channels"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be something like add_group "Channels", "app/channels" if defined?(ActionCable) || defined?(Rails) && Rails::VERSION::MAJOR >= 5 but the below might be cleaner.

SimpleCov.profiles.define "rails5" do
  load_profile "rails"

  add_group "Channels", "app/channels"
end

@colszowka @xaviershay Any preference for adding the group here in all Rails version, with a condition, or making a new rails5 profile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just check for ActionCable. I know that in Rails 5 APIs, ActionCable isn't exactly used much :p

Copy link

@Fudoshiki Fudoshiki Oct 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails 5 can be used w/o AC

add_group "Models", "app/models"
add_group "Mailers", "app/mailers"
add_group "Helpers", "app/helpers"
Expand Down