Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] incorrect pins used in DRV8302 6-PWM example #345

Closed
Abi-64 opened this issue Nov 26, 2023 · 2 comments
Closed

[BUG] incorrect pins used in DRV8302 6-PWM example #345

Abi-64 opened this issue Nov 26, 2023 · 2 comments
Assignees
@runger1101001
Labels
bug Something isn't working
Milestone
2.3.2_Release

Comments

@Abi-64
Copy link

Abi-64 commented Nov 26, 2023

in this example:
examples/hardware_specific_examples/DRV8302_driver/6pwm_example/encoder/full_control_serial/full_control_serial.ino
Line 32:
BLDCDriver6PWM driver = BLDCDriver6PWM(INH_A,INH_A, INH_B,INH_B, INH_C,INL_C, EN_GATE);

Should be:
BLDCDriver6PWM driver = BLDCDriver6PWM(INH_A,INL_A, INH_B,INL_B, INH_C,INL_C, EN_GATE);

Right?
@runger1101001 runger1101001 added bug Something isn't working and removed possible bug labels Nov 28, 2023
@runger1101001 runger1101001 self-assigned this Nov 28, 2023
@runger1101001 runger1101001 added this to the 2.3.2_Release milestone Nov 28, 2023
@runger1101001
Copy link
Member

Yes, it most definately should. Thanks for spotting it! I will fix it right away.

@runger1101001 runger1101001 changed the title [BUG] [BUG] incorrect pins used in DRV8302 6-PWM example Nov 28, 2023
runger1101001 added a commit that referenced this issue Nov 28, 2023
@runger1101001
Merge pull request #350 from runger1101001/dev
31b5c14 
Fix #345
@runger1101001
Copy link
Member

Fixed in #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runger1101001 runger1101001

Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.2_Release
Development

No branches or pull requests
2 participants
@runger1101001 @Abi-64