Add KVO, Combine, and SwiftUI support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jul 16, 2020
|
Thanks for working on this 🙌 |
sindresorhus
requested changes
Jul 17, 2020
sindresorhus
requested changes
Jul 19, 2020
|
Have you tested that all this works in practice? For example, the |
|
>> #42 (comment) << |
|
@sindresorhus sorry for missing this comment. Yes, I tested all possible scenarios of usage. Every toggle updates as expected. |
sindresorhus
changed the title
|
Very nice work. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #27
This PR adds KVO (for storyboards), Combine (simple publisher), and SwiftUI (Binding) support to the library. KVO support was not required by the initial issue, but it simplifies Combine implementation.
LaunchAtLoginwas changed from structure to singleton object.staticisEnabledproperty was left for backward compatibility.