Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepKeys() #94

Merged
merged 8 commits into from
Feb 17, 2022
Merged

Add deepKeys() #94

merged 8 commits into from
Feb 17, 2022

Conversation

Richienb
Copy link
Contributor

Fixes #93

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Copy link
Contributor Author

Richienb commented Feb 13, 2022

The PR is complete, but an AVA bug is causing CI to fail

@sindresorhus
Copy link
Owner

// @mmkal

@sindresorhus
Copy link
Owner

But the one that adds it should make sure to also document the mentioned use-cases for it.

Should mention all the use-cases.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
test.js Outdated Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb marked this pull request as ready for review February 16, 2022 09:04
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

readme.md Outdated Show resolved Hide resolved
test.js Show resolved Hide resolved
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
}), [
'a\\.b.c.d',
'a\\.b.c.d[0]',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be extra thorough you could cover the case where an array contains a complex object too, but I imagine it’s fine.

@sindresorhus sindresorhus merged commit 3902c64 into sindresorhus:main Feb 17, 2022
@sindresorhus
Copy link
Owner

Looks good :)

@AuthorProxy
Copy link
Contributor

@mmkal it doesn't work for empty arrays or objects #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deepKeys helper?
4 participants