Provide an overload for unknown responseType
#1276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Wrapping
got
is difficult with the current function overloads. The changes made in #1051 made things much better, but given aresponseType
of'text' | 'buffer' | 'json'
in the following call:got
will returnCancelableRequest<unknown> | Request
(or justunknown
whenawait
ed) instead ofCancelableRequest<Response<unknown>>
. This change adds an overload that catches the case whereresponseType
isn't statically known, but we do know that aResponse
object will be returned.I haven't added any tests for this PR since this is a type update and I didn't see any tests for types. Given the complexity of the types used by
got
, though, I'm happy to add some if desired. I've had good luck using conditional-type-checks for testing types in the past.Related issues:
#954
#1122