Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TypeScript types conforms to strict mode #928

Merged
merged 83 commits into from
Nov 25, 2019
Merged

Make TypeScript types conforms to strict mode #928

merged 83 commits into from
Nov 25, 2019

Commits on Nov 13, 2019

  1. Add declaration for Reflect.has for type assertion

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    eb38ead View commit details
    Browse the repository at this point in the history

  2. Add DeepPartial utility type

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    e4339f0 View commit details
    Browse the repository at this point in the history

  3. Refactor library types for default values

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    701a738 View commit details
    Browse the repository at this point in the history

  4. Fix utils to be strict mode compatible

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    f150894 View commit details
    Browse the repository at this point in the history

  5. Fix error types

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    9fb4dd1 View commit details
    Browse the repository at this point in the history

  6. Fix type errors related to options merging

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    e56471d View commit details
    Browse the repository at this point in the history

  7. Fix type errors for event emitter

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    eb10198 View commit details
    Browse the repository at this point in the history

  8. Fix type errors for retry calculation

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    e93c3ff View commit details
    Browse the repository at this point in the history

  9. General type cleanup on source code

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    db48597 View commit details
    Browse the repository at this point in the history

  10. Re-order dependencies and enable strict mode

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    02e2e50 View commit details
    Browse the repository at this point in the history

  11. Use global URL instead of imported URL

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    08af93a View commit details
    Browse the repository at this point in the history

  12. Use global URLSearchParams instead of import

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    2552a0f View commit details
    Browse the repository at this point in the history

  13. Linting

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    2ec0170 View commit details
    Browse the repository at this point in the history

  14. Scope variables for Cbs instead of using non-null assertion

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    333817d View commit details
    Browse the repository at this point in the history

  15. Fix dumb code applied during testing

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    85e6dcf View commit details
    Browse the repository at this point in the history

  16. Linting - prefer destructuring

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    0c51020 View commit details
    Browse the repository at this point in the history

  17. Fix typo on defaults and mismatch of object and record

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    858ec60 View commit details
    Browse the repository at this point in the history

  18. Revert changes on errors

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    85446b7 View commit details
    Browse the repository at this point in the history

  19. Fix mistakenly moved lines

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    2332037 View commit details
    Browse the repository at this point in the history

  20. Further enhance types on created instance based on tests

    @pmmmwh
    pmmmwh committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    9864fd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Update types for created got instance and migrate to use type-fest

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    83f5030 View commit details
    Browse the repository at this point in the history

  2. Allow unknown hooks to be injected

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    bd847ae View commit details
    Browse the repository at this point in the history

  3. Linting with XO

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    9d3709b View commit details
    Browse the repository at this point in the history

  4. Add types for create-test-server and slow-stream

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4f9f6a1 View commit details
    Browse the repository at this point in the history

  5. Cleanup promise return types and instance types

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    614a553 View commit details
    Browse the repository at this point in the history

  6. Fix hooks types to be more true

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7660d44 View commit details
    Browse the repository at this point in the history

  7. Type with server test helper

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    94abad7 View commit details
    Browse the repository at this point in the history

  8. Extend with server to allow non promise usage

    @pmmmwh
    pmmmwh committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    984381a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. More fixes on source code based on testing behaviours

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    ca79f35 View commit details
    Browse the repository at this point in the history

  2. Linting and fix ts errors based on new changes

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    130f223 View commit details
    Browse the repository at this point in the history

  3. Add missing types for tests

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    a5ba100 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded tsconfig option

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    4458fda View commit details
    Browse the repository at this point in the history

  5. Fix tests that only require minor type edits

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    dcfe427 View commit details
    Browse the repository at this point in the history

  6. Fix progress test types

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    6d81952 View commit details
    Browse the repository at this point in the history

  7. Fix error tests types

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    2f93c4e View commit details
    Browse the repository at this point in the history

  8. Fix retry tests

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    8d70029 View commit details
    Browse the repository at this point in the history

  9. Fix timeout tests

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    8e6afc9 View commit details
    Browse the repository at this point in the history

  10. Fix: response.req as optional

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    6d07605 View commit details
    Browse the repository at this point in the history

  11. Fix: Make non-enumerable explicit to comply with TS 3.7

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    b2ad971 View commit details
    Browse the repository at this point in the history

  12. Refactor type definitions so that they can be properly picked up

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    e6c923d View commit details
    Browse the repository at this point in the history

  13. Make ts-ignore comments in tests comply with both strict and loose modes

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    10fd85e View commit details
    Browse the repository at this point in the history

  14. Fix type imports for tests

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    acba992 View commit details
    Browse the repository at this point in the history

  15. Fix linting and assertion errors after type changes

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    a9a02ee View commit details
    Browse the repository at this point in the history

  16. Convert type declaration files into type root format to please ts-node

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    15ea6af View commit details
    Browse the repository at this point in the history

  17. Update test types accordingly to new directory structure

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    41351b4 View commit details
    Browse the repository at this point in the history

  18. Apply type roots in tsconfig

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    5545beb View commit details
    Browse the repository at this point in the history

  19. Make tests for errors pass temporarily with a comment on ts 3.7

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    b79a4b7 View commit details
    Browse the repository at this point in the history

  20. Remove GotError instance check

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    5a48e60 View commit details
    Browse the repository at this point in the history

  21. Simplify timed-out as requested

    @pmmmwh
    pmmmwh committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    6675ef3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Update errors to use declare to prevent initialization

    @pmmmwh
    pmmmwh committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    6445fec View commit details
    Browse the repository at this point in the history

  2. Update tests to highlight a bug of Ts 3.7.2

    @pmmmwh
    pmmmwh committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    1038f13 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into enforce-strict-types 

    # Conflicts:
#	source/as-promise.ts
#	source/calculate-retry-delay.ts
#	source/create.ts
#	source/errors.ts
#	source/get-response.ts
#	source/index.ts
#	source/known-hook-events.ts
#	source/merge.ts
#	source/normalize-arguments.ts
#	source/progress.ts
#	source/request-as-event-emitter.ts
#	source/utils/types.ts
#	test/arguments.ts
#	test/cookies.ts
#	test/create.ts
#	test/error.ts
#	test/gzip.ts
#	test/merge-instances.ts
#	test/query.ts
#	test/redirects.ts
#	test/response-parse.ts
    @pmmmwh
    pmmmwh committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    189ddb8 View commit details
    Browse the repository at this point in the history

  4. Fix merge conflicts and lint/type updated source code

    @pmmmwh
    pmmmwh committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    ad698b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Move @types/cacheable-request back to dependencies

    @pmmmwh
    pmmmwh committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    73d6a53 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2019

  1. Fix type errors in source

    @pmmmwh
    pmmmwh committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    cdd5fe1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into enforce-strict-types 

    # Conflicts:
#	package.json
    @pmmmwh
    pmmmwh committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    202f907 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Update promise/stream to accept type arguments

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    cb8a6e6 View commit details
    Browse the repository at this point in the history

  2. Better type response and response body, allow type overloads

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    5468f4e View commit details
    Browse the repository at this point in the history

  3. Fix tests that have trivial type errors

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    47638d7 View commit details
    Browse the repository at this point in the history

  4. Fix linting errors

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    a2db271 View commit details
    Browse the repository at this point in the history

  5. Type tests for cookies

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    8fb0632 View commit details
    Browse the repository at this point in the history

  6. Fix tests for retry

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    a90f1ff View commit details
    Browse the repository at this point in the history

  7. Fix type merging when keys collide

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    e0e6a63 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/master' into enforce-strict-types 

    # Conflicts:
#	source/errors.ts
#	source/get-response.ts
#	source/normalize-arguments.ts
#	source/progress.ts
#	source/request-as-event-emitter.ts
#	test/hooks.ts
#	test/timeout.ts
    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    e54b104 View commit details
    Browse the repository at this point in the history

  9. Fix merge conflicts and new type errors after merge

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    20c2fb7 View commit details
    Browse the repository at this point in the history

  10. Remove key for hooks

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    969d918 View commit details
    Browse the repository at this point in the history

  11. Add comment on useDefineForClassFields for tests

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    8285809 View commit details
    Browse the repository at this point in the history

  12. Update error types

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    35d960a View commit details
    Browse the repository at this point in the history

  13. Better type as-promise

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    a4344e0 View commit details
    Browse the repository at this point in the history

  14. Better type as-stream

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    ce32120 View commit details
    Browse the repository at this point in the history

  15. Fix spacing in package.json

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    0a65461 View commit details
    Browse the repository at this point in the history

  16. Cleanup types for options

    @pmmmwh
    pmmmwh committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    d0c9de7 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2019

  1. Address PR comments and keep types passing

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    ec930bf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into enforce-strict-types 

    # Conflicts:
#	test/progress.ts
    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    279972c View commit details
    Browse the repository at this point in the history

  3. Cleanup for default response as string type

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    13b05b7 View commit details
    Browse the repository at this point in the history

  4. Update Record with any to object syntax

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    71c9f6d View commit details
    Browse the repository at this point in the history

  5. Fix linting error

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    dc7f6ba View commit details
    Browse the repository at this point in the history

  6. Update tsconfig.json

    @sindresorhus
    sindresorhus authored Nov 24, 2019
    Configuration menu
    Copy the full SHA
    95f222a View commit details
    Browse the repository at this point in the history

  7. Fix typo in normalizing arguments

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    d7a40c5 View commit details
    Browse the repository at this point in the history

  8. Fix tests

    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    3177779 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/enforce-strict-types' into enfor… 

    …ce-strict-types
    @pmmmwh
    pmmmwh committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    fca92b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Merge branch 'master' into enforce-strict-types

    @sindresorhus
    sindresorhus authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    7d68f73 View commit details
    Browse the repository at this point in the history

  2. Update normalize-arguments.ts

    @sindresorhus
    sindresorhus authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    4cd6e02 View commit details
    Browse the repository at this point in the history