Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(retry): allow respecting Retry-After for user-defined status codes #598

Merged
merged 8 commits into from
Jul 25, 2024
Merged

feat(retry): allow respecting Retry-After for user-defined status codes #598

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f46f6cc
feat(retry): allow respecting Retry-After for user-defined status codes
Kenneth-Sills Jun 25, 2024
2c71d10
chore: satisfy linter
Kenneth-Sills Jun 25, 2024
adbf1e9
Merge branch 'main' into kesills-customizable-retry-after-statuses
sholladay Jul 1, 2024
e380319
chore: remove debug code
Kenneth-Sills Jul 3, 2024
9bb2658
chore: add missing assertions for requestCount
Kenneth-Sills Jul 3, 2024
f7830d3
refactor: code quality improvement for retry tests
Kenneth-Sills Jul 3, 2024
701293f
docs: removed misleading blurb from README
Kenneth-Sills Jul 3, 2024
526b8fd
docs: copy new docs to inline docblocks as well.
Kenneth-Sills Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove debug code 
How embarassing.
  • Loading branch information
@Kenneth-Sills
Kenneth-Sills committed Jul 3, 2024
commit e380319ac06253088fcbcf90b81fd1d65dafa518
1 change: 0 additions & 1 deletion test/retry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ test('respect custom `afterStatusCodes` (500) with Retry-After header', async t
});

const result = await ky(server.url, {retry: {afterStatusCodes: [500]}}).text();
console.log(result);
t.true(Number(result) >= retryAfterOn500 * 1000);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an assertion for the requestCount.

Looks like some of the other retry tests also have this mistake.

await server.close();
Expand Down