Upgrade TypeScript

[bobjflong]

No description provided.

[bobjflong]

I think it's tricky to use Readonly types here because the {} assignment.

[sindresorhus]

How so? Can you elaborate? If it's not possible to use readonly here, it sounds like a the linter rule should be adjusted to ignore this case.

[bobjflong]

If you type options as

Readonly<Partial<EnqueueOptionsType>> = {}

Then this type error is returned:

Type '{}' is not assignable to type 'Readonly<Partial<EnqueueOptionsType>>'.ts(2322)

And the linter does want options to be Readonly afaict:

source/index.ts:229:58
  ✖  229:58  Parameter should be a read only type

Not an expert, but this indeed could be a linting issue I think. We shouldn't require options to be readonly in this case.

[bobjflong]

Let me know what you'd prefer in this case. Happy to look into that linting thing too if it's confirmed an issue.

[sindresorhus]

If TypeScript doesn't allow it, it's a linter bug. Can you open an issue here: https://github.com/typescript-eslint/typescript-eslint ?

[sindresorhus]

How so? Can you elaborate? If it's not possible to use readonly here, it sounds like a the linter rule should be adjusted to ignore this case.

[sindresorhus]

👌

[bobjflong]

@sindresorhus Without the .eslintignore file, this fails to build for me locally:

[p-queue] npm run test

> p-queue@6.3.0 test /Users/bob/src/p-queue
> xo && npm run build && nyc ava


  bench.ts
  ✖  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: bench.ts.
The file must be included in at least one of the projects provided.      

  test/test.ts
  ✖  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: test/test.ts.
The file must be included in at least one of the projects provided.  

[sindresorhus]

I fixed that by upgrading the xo dependency.

[bobjflong]

Ah, cool