Fix issue with Chrome 67+

[dheerajkumarmadaan]

…D_INPUT anymore. Refactored code to pass empty object if ALLOW_KEYBOARD_INPUT is not found.

[sindresorhus]

In Chrome 68, document.body.webkitRequestFullScreen(Element.ALLOW_KEYBOARD_INPUT) works fine, so I'm not sure what the issue actually is?

[dheerajkumarmadaan]

I tried demo page on chrome 68 and found this error. It is reproducible on multiple system, I can see it is working on some other chrome 68 as well. Not sure what 's the special settings that you need to turn on your chrome to reproduce this.

Assume you cannot reproduce this but below line is still buggy:

elem[request](keyboardAllowed && Element.ALLOW_KEYBOARD_INPUT);
Let say keyboardAllowed is false so this method would be invoked with:
elemrequest
i.r webkitRequestFullScreen(false)

But this method takes object as an argument and it will throw error as specified in screen shot.
This PR will handle this case.

[dheerajkumarmadaan]

[sindresorhus]

I cannot reproduce this on either 68.0.3440.106 or 70.0.3534.0 on macOS. Which exact Chrome version are you on? It might have been fixed in a minor v68 version.

[dheerajkumarmadaan]

I am on 68.0.3440.106

[sindresorhus]

I don't like changing something I cannot reproduce, but alright. Please remove the dist changes. This will be generated on release.

[dheerajkumarmadaan]

Ok.. Removed dist folder changes for screenfull.js

[sindresorhus]

There's still a diff for dist/screenfull.min.js

[amccloud]

@dheerajkumarmadaan @sindresorhus I’m able to reproduce with the same browser/os

Adding error text to this issue so other people can search for it.

TypeError
Failed to execute 'requestFullscreen' on 'Element': parameter 1 ('options') is not an object.

[salilk]

@dheerajkumarmadaan @sindresorhus @amccloud -- I’m also able to reproduce the issue. Looking at the PR - the fix looks good as well as safe. Thanks!!

[dheerajkumarmadaan]

@sindresorhus I just removed dist folder changes.

[shuodashen]

I can reproduce this issue on Chrome Canary, which version is : 72.0.3616.0 (Official Build) canary (64-bit).
Since this commit is merged, I will upgrade to the latest version and try again.

[joedf]

Updating to from v3.3.2 - 2017-10-27 to v4.1.0 - 2019-03-19 worked for me! 👍