Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix direction of toolbar dividers #1202

Merged
merged 3 commits into from
May 7, 2023
Merged

Fix direction of toolbar dividers #1202

merged 3 commits into from
May 7, 2023

Conversation

adil192
Copy link
Contributor

@adil192 adil192 commented May 7, 2023

@bambinoua This PR appears to have broken the example app toolbar (at least on Windows). Please fix: image

@adil192
Copy link
Contributor Author

adil192 commented May 7, 2023

Do you want me to update the CHANGELOG and pubspec?

@adil192 adil192 mentioned this pull request May 7, 2023
Merged
@singerdmx
Copy link
Owner

Yes

@adil192
Copy link
Contributor Author

adil192 commented May 7, 2023

Done!

@singerdmx singerdmx merged commit 6614030 into singerdmx:master May 7, 2023
@adil192 adil192 deleted the fix-axis-divider branch May 7, 2023 17:24
@bambinoua
Copy link
Contributor

bambinoua commented May 8, 2023 •
edited
Loading

Hi @adil192. Is that you made AxisDivider private and remove vertical and horizontal named constructors?

AxisDivider was public because user can fill toolbar children on its own decision and do not use QuillToolbar.basic().

P.S. Now my app is broken!

@adil192
Copy link
Contributor Author

adil192 commented May 8, 2023

Haha looks like we've both broken each other's apps! I'll reverse this later today, unless you want to submit a PR first

@bambinoua
Copy link
Contributor

bambinoua commented May 8, 2023 •
edited
Loading

@adil192 I am already doing it. I cannot wait ;)

P.S. I broken an example app... ;)

@MacDeveloper1 MacDeveloper1 mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adil192 @singerdmx @bambinoua