Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass of tests #1261

Merged
merged 5 commits into from
Jun 13, 2023
Merged

First pass of tests #1261

merged 5 commits into from
Jun 13, 2023

Conversation

richardmarshall
Copy link
Contributor

Adds tests for:

Also adds a new importable library flutter_quill_test that can be used by consumers of this package to assist with testing editor behavior in their apps.

@singerdmx singerdmx merged commit b883f72 into singerdmx:master Jun 13, 2023
@richardmarshall richardmarshall deleted the tests branch June 13, 2023 03:35
@singerdmx
Copy link
Owner

Validating package... (2.0s)
Package validation found the following error:

  • line 2, column 1 of lib/src/test/widget_tester_extension.dart: flutter_test is in the dev_dependencies section of pubspec.yaml. Packages used in lib/ must be declared in the dependencies section.

    2 │ import 'package:flutter_test/flutter_test.dart';
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@singerdmx
Copy link
Owner

@richardmarshall This blocks flutter pub publish

@singerdmx
Copy link
Owner

I am reverting this change.
Please create a new PR once you resolves the publishing issue.

singerdmx pushed a commit that referenced this pull request Jun 13, 2023
@richardmarshall
Copy link
Contributor Author

@singerdmx ok, will look into it.

@richardmarshall
Copy link
Contributor Author

Now aware of the flutter pub publish --dry-run command, will incorporate that into future workflow. Still pretty new to dart and flutter so still learning how all these bits fit together.

@singerdmx I can either add flutter_test to the packages main dependencies list or remove the test helper from lib/. It seems including flutter_test in the dependencies section isn't unheard of as that is what super_editor is doing as well. If you're fine with that change I'll update my branch and submit a new PR.

@singerdmx
Copy link
Owner

I am unfamiliar with the practice so you can make your own call as long as it doesn't break the publishing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants