Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirgration Guide and update README.md #1473

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

EchoEllet
Copy link
Collaborator

Just updating the documentation to be more readable, adding a migration guide, and that almost all

but the important change was changing the version number to 8.0.0
which is something we should have done but I hope we don't make any more breaking changes because we don't want the version number to reach 100 in one month

@singerdmx
Copy link
Owner

I won't be able to publish it until 7 hours later

@EchoEllet
Copy link
Collaborator Author

@singerdmx Wait don't merge yet, I'm getting a warrning

Package validation found the following potential issue:
* Rename the top-level "docs" directory to "doc".
  The Pub layout convention is to use singular directory names.
  Plural names won't be correctly identified by Pub and other tools.
  See https://dart.dev/tools/pub/package-layout.

What do you say?? should we rename the folder from docs to doc to follow the pub convention??

@singerdmx
Copy link
Owner

Sure

@EchoEllet
Copy link
Collaborator Author

I won't be able to publish it until 7 hours later

Sure

Done, do you know how I can chat with @Jon-Salmon in private??

@singerdmx
Copy link
Owner

No idea he is probably in Europe?

@EchoEllet
Copy link
Collaborator Author

No idea he is probably in Europe?

I mean private chat using something like Discord, Slack, Telegram etc...

@singerdmx
Copy link
Owner

No idea

@EchoEllet
Copy link
Collaborator Author

EchoEllet commented Oct 25, 2023

No idea

I think this pull request is ready to merge if you are.
sure we can't publish this yet to pub.dev bu at least the people in GitHub can see the migration guide

@singerdmx singerdmx merged commit 1a6e662 into singerdmx:master Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants