An attemp to fix the text selection bug #1643
Conversation
EchoEllet
commented
Dec 22, 2023
EchoEllet
commented
- An attempt to fix When entering text, selecting all, and then using Command+Z to undo results in an error. #1641
|
@singerdmx Thanks for Flutter Quill. Curious when will this fix be merged? We're in need of it as well. |
I will review it once again today and then merge it |
| ChangeSource.local); | ||
| (selection.baseOffset + len) > 0 | ||
| ? TextSelection.collapsed( | ||
| offset: selection.baseOffset + len, |
There was a problem hiding this comment.
Hi @adil192
Do you know what is len?? in the class HistoryChanged?
There was a problem hiding this comment.
unnecessary file
Thanks! Don't remember how I created it, I use the command line a lot and sometimes I can make such typos
| @@ -218,7 +218,7 @@ class Document { | |||
| if (res.node is Line) { | |||
| return res; | |||
| } | |||
| final block = res.node as Block; | |||
| final block = res.node as Block; // TODO: Can be nullable, handle this case | |||
There was a problem hiding this comment.
If this can be nullable, shouldn't it be as Block?
There was a problem hiding this comment.
If this can be nullable, shouldn't it be
as Block?
I just caught the bug, I didn't write it and I honestly don't know why
