Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web embedBuilder error message typo #1755

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Muhammed-Rahif
Copy link
Contributor

Description

A simple typo fix of error message, when using embedBuilders on web, which is not intended. Should be used editorWebBuilders.

-throw UnsupportedError(
-  'The editorBuilders() is not for web, please use editorBuilders() '
-  'instead',
-);
+throw UnsupportedError(
+  'The editorBuilders() is not for web, please use editorWebBuilders() '
+  'instead',
+);

Resolves the issue #1754.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@singerdmx singerdmx merged commit 52d5664 into singerdmx:master Feb 27, 2024
1 of 2 checks passed
@Muhammed-Rahif Muhammed-Rahif deleted the fix-error-msg branch February 28, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants